Commit graph

1243 commits

Author SHA1 Message Date
LevelX2
89350f1a91 [OGW] Added Oath of Gideon, Wall of Resurgence and Cultivator Drone. 2016-01-10 12:02:46 +01:00
LevelX2
c8f82b49ff Added possibility to check kind of cost to pay for conditional mana use. 2016-01-10 12:01:58 +01:00
LevelX2
782190bac3 Some changes to mana handling to handle {C} mana. 2016-01-08 23:25:42 +01:00
LevelX2
0e4de763d8 * Splinter Twin - Fixed that no token was created if the enchnated permanent left battlefield meanwhile (fixes #1429). 2016-01-08 15:07:41 +01:00
LevelX2
e9f58d20a5 * Fossil Find - Fixed card movement handling. 2016-01-06 22:11:09 +01:00
LevelX2
4f2c21a146 * Fixed a bug that target event was wrongly created if effects like chnage target of Spellskite didn't change the target. 2016-01-02 16:31:42 +01:00
LevelX2
7676c5e894 [OGW] Added General Tazri and Stone Haven Outfitter. 2016-01-01 14:10:40 +01:00
LevelX2
554e81a462 * Hideaway - Fixed that the face down card played by hideaway was not correctly set face up again. 2015-12-31 12:05:08 +01:00
LevelX2
9f22eb0688 * Fixed that cards without cost (e.g. Ancestral Vision) could be cast from graveyard (e.g. by using Yawgmoth Will). Fixed that cards could be suspended from graveyard (e.g. with Yawgmoth Will). 2015-12-31 11:01:52 +01:00
LevelX2
af5ff0f407 [OGW] Fixed Surge to work with triggered abilities of permanents. 2015-12-30 11:24:55 +01:00
Quercitron
c73cee90a5 * Laquatus's Champion - Fix that player didn't get life when Laquatus's Champion left the battlefield 2015-12-30 02:03:44 +03:00
Quercitron
88ca1ec1b0 Fix player targets processing in tests 2015-12-30 01:54:51 +03:00
LevelX2
dcfb593059 * Added a test. 2015-12-25 16:14:58 +01:00
LevelX2
e7e290e787 * Archfiend of Depravity - Outcome tweaked for AI behaviour. 2015-12-25 11:45:55 +01:00
LevelX2
eb0ae55257 * Fixed a problem with "put into the graveyard from anywhere triggers" that checked wrongly the state of the source object on the battlefield if went to graveyard itself. 2015-12-24 17:58:04 +01:00
LevelX2
aecb2c8829 [OGW] Added surge and Crush of Tentacles. 2015-12-24 10:02:11 +01:00
LevelX2
c83f906525 * Fixed some cards doing preventable non combat damage but handled the damage wrongly as non preventable combat damage. 2015-12-23 16:38:56 +01:00
LevelX2
131d3af759 * Started adding the new colorless mana {C}. Not finished yet but the exception is removed. 2015-12-16 12:40:10 +01:00
LevelX2
aa07fcecd5 * Fixed a bug that P/T set of target animated lands (e.g. by Awaken) were set in the wrong sublayer so that the P/T of self animated lands (e.g. Shambling Vent) were always overwritten desite their ability time stamp. 2015-12-16 12:36:09 +01:00
LevelX2
855ac6e4e1 * Hallowed Moonlight - Fixed a bug in the way cards were moved to exile. 2015-12-14 23:26:16 +01:00
LevelX2
803b948a66 Added a test. 2015-12-14 12:16:17 +01:00
LevelX2
207f486afc * Xmage 1.4.6v0 2015-12-13 19:47:04 +01:00
LevelX2
ac7cd27f34 * Added test and some minor changes. 2015-12-13 19:18:26 +01:00
LevelX2
ae34fd795a * Savage Summoning - Fixed that the +1/+1 counter was not added. 2015-12-13 18:10:55 +01:00
LevelX2
8b5272cb64 * Fixed a problem that the controller of triggered abilities was set to a false value if the source object of the triggered ability was removed from battlefield at the same time as other objects (fixes #1417). 2015-12-12 17:36:12 +01:00
fireshoes
692fe8046e Merge origin/master 2015-12-11 16:13:39 -06:00
fireshoes
636f2d960e Updated text of cards that add colorless mana to use {C}. Added ExileSourceUnlessPaysEffect. Added some random cards. 2015-12-11 16:12:46 -06:00
LevelX2
0488da6b22 * Amoeboid Changeling, Wings of Veles-Vel - Fixed that the character types were changed on the wrong layer. 2015-12-08 15:24:24 +01:00
LevelX2
4d01eb143a Redesigned handling of attack allowed check related to the complete attack. 2015-12-08 12:20:37 +01:00
LevelX2
15a884c00c * Added a test. 2015-12-07 17:19:37 +01:00
LevelX2
259d6744ae * Fixed that casting spells without mana costs did not work correctly for spells with mono hybrid mana costs (e.g. Beseech the Queen by Omniscience) fixes #1404. 2015-12-06 09:37:45 +01:00
LevelX2
74d2ff0316 * Perplexing Chimera - Fixed that the control effect was not discarded as Perplexing Chimera changed zone. 2015-12-04 19:00:10 +01:00
LevelX2
0af5ed4e7b * Chandra's Phoenix - Fixed check for source object doing damage to opponents. 2015-12-03 16:36:30 +01:00
poixen
46eb6c0525 Restructured Mage module 2015-11-29 21:56:49 +01:00
Neil Gentleman
e678577720 run Mage.Tests with a fresh card db
currently tests are failing in Jenkins
2015-11-28 21:35:07 -08:00
Neil Gentleman
bfb428b13a always use log4j
removed all references to mage.util.Logging, java.util.logging

transient static doesn't mean anything, since static fields are never
included in serialization
2015-11-28 21:11:25 -08:00
Quercitron
28a087812a Add comments to Turntimber Basilisk test 2015-11-29 00:31:38 +03:00
Quercitron
b9add2e041 * Turntimber Basilisk - Fix a bug when a creature that must be blocked is not attacking 2015-11-29 00:19:21 +03:00
LevelX2
d94a2712ba * Fixed a bug that a dies ability did still trigger as the stack was not cleared meanwhile. 2015-11-28 12:52:13 +01:00
LevelX2
f23756c20b * Fixed that DiesThisOrAnotherCreatureTriggeredAbility did not work if the source died itself (e.g. Omnath, Locus of Rage). 2015-11-27 12:27:46 +01:00
LevelX2
eb6a5e7dcb * Some rework of play card effects. 2015-11-26 17:06:50 +01:00
LevelX2
780702be1b * Fixed some problems with replaced play land special action. 2015-11-26 10:48:40 +01:00
LevelX2
e51c4d5f67 * Fixed a bug where wrongly a card object was moved for a copied spell. 2015-11-26 00:48:28 +01:00
poixen
3ffb11d2e9 Updated mana class to pass failing tests 2015-11-25 19:57:11 +01:00
LevelX2
b637d2c65c * Fixed layer problem of BecomesCreatureSourceEffect (causes Chimeric Mass to die after entering the Battlefield). 2015-11-25 14:51:41 +01:00
LevelX2
62992d46db Fixed the sometimes failing Evolve test. 2015-11-25 14:50:27 +01:00
Neil Gentleman
f83cb32ed3 don't use <i/> to end italic text
it's not correct html, and causes all following text to render italic.

only visible on a few cards, because reminder text typically comes at
the end of line.
2015-11-25 00:32:00 -08:00
LevelX2
db669f02d5 * Zada, Hedron Grinder - Fixed that the spell copy target setting did not work correctly for targets that optional allowed more than one target creature (e.g. spells with Strive). 2015-11-24 17:07:52 +01:00
LevelX2
d65b236d0a Added some tests. 2015-11-24 16:37:43 +01:00
LevelX2
8c0b615faf Merge pull request #1380 from poixen/evolveTestFix
Fixed broken evolve test
2015-11-24 09:08:22 +01:00
Neil Gentleman
085b00499c fix Grinning Totem
the exiled card wouldn't be put in its owner's graveyard if Grinning Totem
changed zones before the delayed trigger

any cards using CardUtil.getCardExileZoneId for delayed effects are likely
broken in the same way
2015-11-22 18:40:46 -08:00
Neil Gentleman
230d1d37bd fix Grinning Totem, Thada Adel, Commune with Lava
opponent was able to cast the exiled cards

also changed Knacksaw Clique to use the same templating as Ornate Kanzashi
2015-11-22 18:40:38 -08:00
Neil Gentleman
f06de472a4 fix Hostility
was preventing damage to opponents regardless of source
2015-11-22 18:00:28 -08:00
Neil Gentleman
038d02e8d7 add test for non-standard booster generation 2015-11-21 18:35:10 -08:00
LevelX2
96bc3172f5 * Fixed a problem of returning cards from exile (e.g. Fiend Hunter) if the triggering permanent made multiple zone changes before the left battlefield triggered ability resolved to return the exiled permanents. 2015-11-21 23:41:41 +01:00
poixen
b0da2f2260 Merge pull request #1378 from poixen/mana_cleanup
Removed minus subtraction limits
2015-11-21 12:06:02 +01:00
poixen
a5242ff087 resolved conflicts 2015-11-21 12:02:55 +01:00
poixen
5c6bdfceb8 Merge pull request #1379 from poixen/manasymbol
Manasymbol
2015-11-21 11:47:28 +01:00
LevelX2
0d86e8e063 Xmage 1.4.5v0 2015-11-21 10:33:43 +01:00
poixen
bb8137c81a Fixed broken evolve test
As mentioned in the test comments:

“* I take two Ivy Lane Denizen on to the stack and then Renegade
Krasis's Evolve
     * Ability, so resolving Renegade Krasis's Evolve Ability is first
. (Maybe
     * Ivy Lane Denizen's target is any.) When Renegade Krasis's Evolve
Ability
     * resolves, +1/+1 counter is placed on it, but doesn't triggers
Renegade
     * Krasis's second ability.”

This means that Renegade dent put a counter on Adaptive, as the ivy +1
triggers are still on the stack
2015-11-21 00:12:23 +01:00
poixen
f2972c5b8e Updated Phyrexian Mana
+ “A Phyrexian mana symbol represents a cost that can be paid either
with *one mana of its color* or by paying 2 life”. These symbols are
mono colored, as such I have made them so.
+ Added test cases for phyrexian mana symbols
2015-11-20 22:43:26 +01:00
poixen
6138af0ffb Added Snow Mana Test
+ Added test case for snow mana
2015-11-20 22:29:49 +01:00
poixen
09ea717ed3 Added Hybrid Mana Tests
+ Added hybrid mana test cases
2015-11-20 22:24:55 +01:00
poixen
f34e69308e Updated mono colored hybrid mana type
+ “107.4e. Hybrid mana symbols are also colored mana symbols.” I have
added the Type COLORED to each mono hybrid symbol
+ added tests for hybrid mana symbols
2015-11-20 22:07:24 +01:00
poixen
f6cc03ec44 Added W mana test case
Added U mana test case
Added B mana test case
Added R mana test case
Added G mana test case
2015-11-20 20:59:52 +01:00
poixen
56be135532 Removed minus subtraction limits
+ Removed minus subtraction limits to allow other areas of code to work
2015-11-20 17:22:48 +01:00
LevelX2
8a133a43d0 Added test for Mana.enough method. 2015-11-20 15:06:00 +01:00
Quercitron
7e58dc70d5 Update Swiss tournament pairing - For the last round, for each unpaired player pair against the highest ranked player they haven't played against 2015-11-20 02:54:50 +03:00
LevelX2
b30a6c4b15 * Cryptoplasm - Fixed that the copied creature did not have the triggered ability (fixes #1367). 2015-11-19 23:28:12 +01:00
LevelX2
c4ab5806e0 Revert "Mana Class Overhaul" 2015-11-19 22:59:57 +01:00
LevelX2
68ff09c219 Revert "Mana updates" 2015-11-19 22:59:15 +01:00
LevelX2
f4871fe489 Merge pull request #1375 from poixen/mana_cleanup
Mana updates
2015-11-19 22:37:14 +01:00
poixen
05b841577a added subtraction logic to enough()
+ added subornation logic to enough(). We do not want to mix the public
subtract() call with this method. As doing so would mean that either a)
subtraction can go below 0 (this should not happen) or b) we break this
function with exceptions. This is a work around for these scenarios.
2015-11-19 17:42:59 +01:00
poixen
2c617a6aaf Mana updates
+ calling subtraction will now throw an exception if you try and use
more mana than is available. This is better than setting it to 0.
Setting to 0 impose that you should still be allowed to perform the
action.
+ updated subtraction test to check for exception
+ subtractionCost() will not allow using mana that is not available,
same as subtract()
2015-11-19 17:09:40 +01:00
LevelX2
ec7c888044 Some fixes to put token onto battlefield handling of cards. Some minor reworks. 2015-11-19 15:52:45 +01:00
LevelX2
7bb5d1bb43 Merge pull request #1374 from poixen/mana_cleanup
Mana Class Overhaul
2015-11-19 14:37:39 +01:00
Quercitron
486d547f5e Fix Swiss pairing for the case when some players have left the tournament 2015-11-19 13:18:43 +03:00
poixen
1f5638539f Class Overhaul
+ added javadoc
+ added final to method variables that should not be mutated
+ Mana can no longer be initialised with minus values
+ added null assertions
+ renamed ‘addXXX’ to ‘increaseXXX’. Add implies that you are able to
add variable amounts.
+ subtraction can no longer allow minus values.
+ removed unused state
+ refactored classes use renamed/removed mana calls
+ added comment to contains(), needs to be looked into?
+ Added validation to setting of mana. Can no longer be set to minus
values. Will log if an attempt is made
+Added comment to static mana, this is unsafe.
2015-11-19 09:53:52 +01:00
Quercitron
05a789cd8b Use approach with minimal weight matching to determine Swiss tournament pairings 2015-11-19 02:58:02 +03:00
LevelX2
7044e58231 [C15] Added Scourge of Nel Toth. 2015-11-18 17:39:32 +01:00
LevelX2
70bce1c082 * Void Winnower - Fixed that the check for even casting costs did not work correctly. 2015-11-14 11:24:26 +01:00
LevelX2
d3000da3a3 * Void Winnower - Fixed that the check for even casting costs did not work correctly. 2015-11-14 11:14:50 +01:00
LevelX2
50b5602459 * Conflagrate - Fixed that the damage amount could be calulated if cast by flashback. 2015-11-14 10:01:13 +01:00
LevelX2
1335d58e77 * Collapsing Borders - Fixed that it did not give life to players. 2015-11-14 02:33:24 +01:00
LevelX2
4711e0cf99 Changed ability handling of modal spells to be able to select the same mode multiple times with different targets. 2015-11-14 01:56:56 +01:00
LevelX2
431d0005f2 Updated modes to handle selection of modes multiple times (not working yet if targets included). 2015-11-08 20:07:02 +01:00
LevelX2
6f2d3a18c0 [C15] Added Myriad keyword. 2015-11-08 11:51:36 +01:00
LevelX2
f3e8a93316 * Renegade Krasis - Fixed that check if Renegade Krasis was evolved did not always work correctly. 2015-11-07 21:21:03 +01:00
LevelX2
b1c3d690f5 * Fixed some ability and subtype removing effects (fixes #1352). 2015-11-07 12:29:31 +01:00
LevelX2
27ae613ce8 * Fixed handling of zoneChangeCounter of PermanentCard (fixes #1353). 2015-11-06 12:28:58 +01:00
LevelX2
3de7ff6808 * Some rework of card moving after spell countering. 2015-11-05 00:37:30 +01:00
LevelX2
1139495fd7 * SetPowerToughnessSourceEffect - Set the correct sublayer to use (fixes #1354). 2015-11-04 22:31:35 +01:00
LevelX2
af18f95bba Minor changes. 2015-11-04 17:16:45 +01:00
LevelX2
54d28550b4 Added a test. 2015-11-04 12:28:48 +01:00
LevelX2
2e49a74aab * Fixed test with Flashback and converge. 2015-10-31 10:32:45 +01:00
LevelX2
3beb5568c4 * Karn Liberated - Fixed that commanders were not returned to command zone after game reset. 2015-10-31 00:55:12 +01:00
LevelX2
e0c1492f88 * Fixed a problem that the AI was locked if a attack fee has to be paid but the AI was not able to pay the costs. 2015-10-30 22:34:42 +01:00
LevelX2
2153d5ccf5 * Fixed that for spells cast with flashback values calculated from the paid mana (e.g. Converge) did not work correctly. 2015-10-30 00:30:53 +01:00
LevelX2
d79776e589 * Added some tests. 2015-10-28 17:05:58 +01:00
Neil Gentleman
0c988de9fb fix Impelled Giant 2015-10-27 20:24:57 -07:00
LevelX2
5c31b03c00 * Fixed a problem that ability controller of replacement effects for cards entering the battlefield were not changed early enough (e.g. causing problem if putting Canopy Vista of opponent with Oblivion Sower onto th ebattlefield). 2015-10-27 17:55:38 +01:00
Toby Lawrence
d42e5fed78 Razorverge Thicket should enter untapped only if you control two or less lands. 2015-10-25 17:58:20 -04:00
LevelX2
f14cbb7f36 * Fixed a bug with removing spells from stack (e.g. Split Second had some problems) fixes #1333. 2015-10-23 18:25:36 +02:00
LevelX2
92bcd0d522 * Changed some more card movement handling. 2015-10-22 23:02:07 +02:00
LevelX2
2aaea46dc6 * Fixed that the exile and return effect of the flip planeswalker did not always work correctly. 2015-10-22 15:38:50 +02:00
LevelX2
af67e27bcd * Alesha, Who Smiles at Death - Fixed that the move card to battlefield worked not correctly. 2015-10-22 15:37:58 +02:00
LevelX2
4629366ae7 * Fixed that spells without mana costs but suspend could be cast with no mana (e.g. Ancestral Vision). 2015-10-21 20:16:52 +02:00
LevelX2
d906fc8c00 * Fixed that damage redirection to planeswalker did cause an exception. 2015-10-21 15:35:58 +02:00
LevelX2
d20bbcfe0b * Fixed that permanents brought onto battlefield by search abilities were always tapped. 2015-10-21 15:14:20 +02:00
LevelX2
701a722904 * Fixed some redirect effect sthat were implemented as prevention effects (fixes #1216). 2015-10-20 22:58:24 +02:00
LevelX2
d58288da6d Some changes to RedirectionEffect class. Fixed that Harm's Way and Shaman en-Kor prevented the damage instead of only redirecting the damage. 2015-10-20 17:16:13 +02:00
LevelX2
606bf4d6e0 * Fixed that it was not possible to play spells without costs with alternative costs (e.g. Ancestral Visions with Omniscience). Fixed that playing spells with alternate costs did also remove additional costs (e.g. card with entwine cast with Omniscience). 2015-10-20 00:44:32 +02:00
LevelX2
7c35a69360 * Fixed a bug that if copied spells should be shuffled into the library the original spell was removed from the stack. 2015-10-19 22:36:28 +02:00
Neil Gentleman
3817118bc0 Fix 'Of', 'By' and 'The' in card names 2015-10-19 00:44:26 -07:00
LevelX2
415700ccb2 * Some more changes for rework of ENTERS_THE_BATTLEFIELD event and card movement. 2015-10-18 23:33:23 +02:00
LevelX2
4216fbab8c * Some more changes for tework ENTERS_THE_BATTLEFIELD event for replacement effects. 2015-10-18 11:11:48 +02:00
LevelX2
d145885d2d * Sylvan Library - Fixed that a player that controlled a Sylvan Library from another player was not forced to play life for cards he kept from Sylvan Library's triggered ability (fixes #1307). 2015-10-18 10:21:12 +02:00
LevelX2
4243a1d3a3 Merge origin/master
Conflicts:
	Mage.Sets/src/mage/sets/gatecrash/MasterBiomancer.java
2015-10-17 16:33:05 +02:00
LevelX2
59ef2a2889 * Reworked ENTERS_THE_BATTLEFIELD event for replacement effects. Some rework to card movement. 2015-10-17 16:30:28 +02:00
LevelX2
597d530a37 Some minor changes. 2015-10-16 15:03:40 +02:00
LevelX2
d264dd83e1 * Replaced some custom card effects. Updated enters battlefield replacement effects for new handling. 2015-10-15 23:47:06 +02:00
LevelX2
046da0f5d1 * Some changed to card moving (not finished) 2015-10-15 08:32:58 +02:00
LevelX2
52d0adcac1 Fixed some problems with UUID comparing and some problems with card moving. 2015-10-14 17:54:55 +02:00
LevelX2
e166018027 * Fixed that continuous effects were not yet applied to lands entering the battlefield (preventing Prismatic Omen and Valakut the Molten Pinnacle combo to work). 2015-10-13 22:35:50 +02:00
LevelX2
00f48b005d Added test. 2015-10-12 23:50:29 +02:00
LevelX2
288a1ec02c * Oath of Lieges - Fixed target handling (fixes #1312). 2015-10-12 23:10:16 +02:00
LevelX2
303362fa12 * Paradox Haze - Fixed that check if a step is the first upkeep step of a turn did not work always correctly (fixes #1313). 2015-10-12 17:35:04 +02:00
LevelX2
aa525bf0d2 Merge origin/master 2015-10-12 09:12:22 +02:00
LevelX2
8dd9fbea40 Conspire - The player is now asked to use conspire only if he is able to pay the tap costs. 2015-10-11 23:56:29 +02:00
LevelX2
981a27ccbf * Fate transfer - Fixed that +1/+1 or -1/-1 counters on target permanent were not applied. 2015-10-11 18:13:14 +02:00
LevelX2
8b8097878c * Reworked/Cleaned card movement handling. 2015-10-11 03:52:38 +02:00
LevelX2
819d341fbb * Nissa, Sage Animist - Added test for +1 ability. 2015-10-09 14:55:39 +02:00
LevelX2
987280c4e7 * Blizzard Specter - Fixed that the seond mode (discard) did not work. 2015-10-09 14:22:21 +02:00
LevelX2
d8cf0d7a4b Fixed that land enchantments that caused the enchanted land to become a basic land type removed wrongly other card types than Land and non basic land subtypes (e.g. Spreding Seas enchanting animated Blinkmoth Nexus). 2015-10-09 00:13:41 +02:00
LevelX2
cb250a065a Fixed that triggered abilities from sacrificed permanents did also trigger if the permanent was face down before the sacrifice. 2015-10-07 17:47:25 +02:00
LevelX2
f24a1b3898 * Fixed check of dies attched triggered abilities not always triggering if attachment and attached object went to graveyard at the same time. 2015-10-03 19:23:58 +02:00
LevelX2
85f0cc6bb3 Fixed variable remove counter costs to work also correctly if X=0 (e.g. Retribution of the Ancients and Willbreaker). 2015-10-03 18:22:14 +02:00
LevelX2
f6ec543b1b TestPlayer fixed that target events created by RestPlayer are reset back if ability activation failed. 2015-10-03 18:20:59 +02:00
LevelX2
7b68604471 Some changes/fixes to conspire ability. 2015-10-03 13:33:22 +02:00
emerald000
435eb49b58 Added missing Licids + tests (including 2 failing tests). 2015-10-02 23:38:11 -04:00
LevelX2
63c6aa226a * Spellskite - Fixed a bug that wrong log message was written if target was chnaged from a player to spellskite. 2015-10-01 22:01:49 +02:00
LevelX2
4b41628032 * Added test. 2015-09-30 16:58:03 +02:00
LevelX2
8044940a97 * Fixed a bug that if all targets (if targets were set) of a spell with an up to target definition (e.g. Adverse Conditions) became illegal the spell did not fizzle as it should. 2015-09-30 00:53:33 +02:00
LevelX2
0d755b3c89 Some minor changes. 2015-09-29 17:37:51 +02:00
LevelX2
6cc2ac0e70 * Zada, Hedron Grinder - Fixed a bug with checking and copying modal spells. 2015-09-28 19:27:51 +02:00
LevelX2
0680560225 * Compost - Fixed that it triggered for all cards going to opponents graveyard (instead of only black cards). 2015-09-28 15:14:50 +02:00
LevelX2
7650f53dee * Rosheen Meanderer - Fixed that the created conditional mana could only be used for spells. 2015-09-27 10:29:30 +02:00
LevelX2
9e1111748d * Enslave - Fixed that the set source of the damge was wrong. 2015-09-27 09:23:40 +02:00
LevelX2
f22fb380b7 * Reaper of Sheoldred - Fixed that damage was sometimes dealt to Reaper of Sheoldred controller. 2015-09-27 01:21:47 +02:00
LevelX2
46fa935172 * Emrakul, the Aeons Torn, Ulamog, the Infinite Gyre, Kozilek, Butcher of Truth - Fixed that the shuffle graveyard to library was wrongly done for the controller of instead the owner. 2015-09-27 00:22:51 +02:00