Commit graph

1729 commits

Author SHA1 Message Date
Nathaniel Brandes
d7d700f66a Some clarification around loyalty. Added unit test. 2017-03-09 02:30:52 -08:00
Nathaniel Brandes
dd0c89db1d Fix Dack Fayden Emblem.
The emblem's effect was referencing the permanent directly.
This meant that if the permanent left and came back, the control effect
would start working again.
2017-03-09 02:24:34 -08:00
Justin Herlehy
9dd1e60f2d Implement Clutch of Undeath
Implement Clutch of Undeath and add test to ensure functionality.
2017-03-09 01:48:34 -08:00
Justin Herlehy
1a2724c9b2 Revert: Fix planeswalker loyalty counters.
This change was incorrect.

Gatherer Ruling:
10/1/2005: Planeswalkers will enter the battlefield with double the normal amount of loyalty counters. However, if you activate an ability whose cost has you put loyalty counters on a planeswalker, the number you put on isn’t doubled. This is because those counters are put on as a cost, not as an effect.
2017-03-09 01:14:10 -08:00
Nathaniel Brandes
52fa369024 Fix planeswalker loyalty counters.
They should be added like normal counters, firing events that can be
intercepted by cards like doubling season.
2017-03-08 23:57:11 -08:00
Nathaniel Brandes
ce1f4a3bf8 Phyrexian mana now correctly a payment choice.
Per rule 601.2b, it is not determined at the pay costs step,
but at the "choice" step, long before costs are determined.

This fixes trinisphere interactions and should be consistent with the
rules.
2017-03-08 20:03:28 -08:00
Jeff
209e2d13c1 - Fix for Spellskite in situations where it was also a target. Fixed the test for Spellskite. 2017-03-08 12:05:36 -06:00
Achilles
f5d13944a6 - Test for Auratouched Mage. The tests worked fine in the game, but the test suite can't handle it yet. 2017-03-07 20:52:13 -06:00
Derek M
2ff68c2fb3 Merge pull request #2944 from Alexsandr0x/sakashima-bug
SpellStutter Sprite - Sakashima Impostor Bug
2017-03-07 16:10:06 -05:00
Alexsandro
b83bc9d68a Assert if Sakashima copied SpellStutter by S/T 2017-03-06 21:11:09 -03:00
Derek Monturo
3b6ffe9382 #2157 Linvala tests on activated abilities 2017-03-06 17:02:23 -05:00
Derek Monturo
e28dd5aef7 minor added another assert 2017-03-06 16:34:52 -05:00
Derek Monturo
f93524a0f7 #2135 added test for clever impersonator copying an aura 2017-03-06 16:32:40 -05:00
Alexsandro
d98e43ded2 Create test class to validate error 2017-03-06 16:15:17 -03:00
Alexsandro
6fb344a306 Create test class to validate error 2017-03-06 16:15:02 -03:00
Derek Monturo
c53c0d2e9e #2832 test for Athreos not triggering on Cartel sac ability 2017-03-06 14:12:38 -05:00
drmDev
2aa1ee2471 minor mod 2017-03-05 12:17:17 -05:00
drmDev
594e22a245 tests for GrandArbiter cost reduction and increase based on reported bug. unconfirmed 2017-03-05 12:16:12 -05:00
drmDev
c8e41bc002 Phyrexian Purge impl and tests 2017-03-05 10:37:05 -05:00
drmDev
4bfa956368 more tests for Nacatl must be blocked 2017-03-05 07:54:55 -05:00
ingmargoudt
b5e8c88153 remove all contains(cardtype.XX) references, instead use the default interface method 2017-03-05 09:14:33 +01:00
Nathaniel Brandes
1d3ebb749d Fix omniscience effect for colorless mana.
Also unified the tests for omniscience into a single file, and
put the effect into a single class so that Tamiyo and Omniscience
can share implementations.
2017-03-04 23:04:11 -08:00
drmDev
6d20c7a996 added test for Nacatl War-Pride 2017-03-04 18:54:29 -05:00
ingmargoudt
5a57731968 added new helper methods to test for CardType, to get rid of the contains(CardType.XXX) everywhere, put the logic of that in one place and use the interface call 2017-03-04 00:16:36 +01:00
ingmargoudt
372584f7ad changed cardtype from list to enumset 2017-03-03 17:04:32 +01:00
vraskulin
11dc1e10f1 Few lambda's and removed explicit type from creating lists and hashmaps 2017-02-28 13:46:57 +03:00
vraskulin
0a3c95dde5 Inner classes should be static. It reduces memory usage and gives perfomance boost + DeckImporter rollback 2017-02-28 12:40:12 +03:00
doncarton
5eaaa67d1e Nulls to optional. Also there was bug with AetherChaser "you may pay" was not set to optional 2017-02-26 15:15:54 +03:00
Goesta
e9d103b70e Fixed BouncingACrewedVehicle test 2017-02-22 23:25:15 +01:00
ingmargoudt
a98df9a28e fix javadoc 2017-02-19 09:13:19 +01:00
ingmargoudt
9ea690797f the card should still be exiled.
added a method to test exile count per player
added a test for chandrapyromaster
2017-02-19 09:09:43 +01:00
LevelX2
899046cf16 * Gratuitous Violence - FIxed that if the damage of a creature with lifelink was doubeled only the non doubled amount was added to life. 2017-02-18 01:26:02 +01:00
ingmargoudt
7d655ce745 Merge pull request #2866 from goesta/BouncingCrewedVehicleTest
Bouncing crewed vehicle test
2017-02-15 23:55:11 +01:00
vraskulin
a15220d51e Bugfixes with != instead of equals and default toString calls 2017-02-15 19:52:20 +03:00
Goesta
338baa546e Added bouncing a crewed vehicle will uncrew it test 2017-02-14 21:24:53 +01:00
Goesta
5ece29e5d7 Added assertNotType test assertion 2017-02-14 21:19:47 +01:00
LevelX2
7f866f1b21 Merge pull request #2859 from goesta/FlusterstormTest
Added Flusterstorm test
2017-02-13 00:06:45 +01:00
LevelX2
2e8d68aa4b Merge pull request #2858 from goesta/SpellskiteTest
Added Spellskite split damage test
2017-02-13 00:06:17 +01:00
Goesta
0bccc7ab49 Added Flusterstorm test 2017-02-12 05:32:25 +01:00
Goesta
b39996e1eb Added Spellskite spit damage test 2017-02-12 04:30:01 +01:00
Goesta
ce78f64fab Added test for Champion of Lambholt 2017-02-11 23:45:20 +01:00
Goesta
a21128932b Added Test for Kalastria Healer 2017-02-11 20:18:46 +01:00
Jeff
fc3ecdf8d0 - Added Auratouched Mage and test suite. 2017-02-10 10:15:56 -06:00
Jeff
1e82f0750a Fixed FlashbackTest and made modifications to CascadeAbility allowing it to pass its test suite. 2017-02-09 10:20:21 -06:00
vraskulin
0557b5e89c list.size > 0 changed to !list.isEmpty
We care about if it's empty or not, not about it's size
2017-02-06 14:32:51 +03:00
vraskulin
f60ebfbb1f All 1-character strings converted to primitives
"b" + "r" now changed to 'b' + 'w'.  It's more straight-forward, and may cause perfomance improvements - character primitives allocation is faster and less expensive than string creation.
2017-02-06 14:32:51 +03:00
vraskulin
31589778ca Try/finally refactored to try with resources 2017-02-06 14:32:11 +03:00
LevelX2
ff6d79829e * Fixed a bug that damage was wrongly still assigned to players during combat that already left the game. 2017-02-04 23:56:03 +01:00
LevelX2
0dacf2a6fa * Fixed that the cascade converted mana costs comparison did not work correctly with split spells. 2017-02-04 14:26:17 +01:00
LevelX2
067b72dcce * Added test. 2017-02-03 21:36:33 +01:00
LevelX2
96d2372a2b Added revolt test. 2017-01-31 17:06:17 +01:00
LevelX2
3968cdcce9 Added Glimpse of Nature test. 2017-01-31 16:33:37 +01:00
LevelX2
038f21e882 Added Glimpse of Nature test. 2017-01-31 16:32:59 +01:00
LevelX2
ada17b1690 * Reyhan, Last of the Abzan - Fixed that dies triggered ability was not reset correctly if it triggered multiple times. 2017-01-30 21:49:57 +01:00
LevelX2
034ef22468 * Fixed PreventDamageByTargetEffect to handle delayed spell damge (fixes #2822). 2017-01-30 21:19:17 +01:00
LevelX2
0a1356d40e * Fixes to test and fix for issue #2816 2017-01-29 11:16:04 +01:00
LevelX2
2cf15830d7 * Some fixes to Hivestone and BecomesSubtyoeAllEffect. 2017-01-29 11:15:09 +01:00
LevelX2
d3dd52a900 Merge pull request #2818 from goblin/fix_2816
test and fix for issue #2816
2017-01-28 11:31:09 +01:00
goblin
907a12b6d2 oops, remove debug logs and fix whitespace
that wasn't meant to be committed
2017-01-27 05:02:42 +01:00
goblin
96aa224652 prevent Kessig from transforming each turn
it was messing up the test
2017-01-27 05:00:15 +01:00
goblin
89e079fb9d add license note
not sure about BetaSteward, but might as well
2017-01-27 04:27:02 +01:00
goblin
99cb632150 block Kessig in that test, not Werewolf 2017-01-27 00:56:01 +01:00
goblin
0f9ede42bd also test Kessig Forgemaster
the other face of that card has a similar ability that needs fixing
2017-01-27 00:20:47 +01:00
goblin
ae8e121e90 fix up whitespace
XMage people seem to be using spaces...
2017-01-27 00:09:46 +01:00
goblin
0833e4b81f test for issue #2816 2017-01-27 00:04:09 +01:00
LevelX2
448ec24bcc Merge origin/master 2017-01-25 16:05:40 +01:00
LevelX2
7fdb044775 * Added one more test for Gonti, Lord of Luxury, 2017-01-25 16:05:12 +01:00
LevelX2
357d566e63 Merge pull request #2774 from Alexsandr0x/master
Add 2 cards
2017-01-24 23:18:01 +01:00
LevelX2
682940eca6 Added test. 2017-01-22 23:00:25 +01:00
LevelX2
fdd28cde4b * Possibility Storm - Fixed a problem with split card moving. 2017-01-22 22:04:50 +01:00
LevelX2
ce8d752f22 * Fairgrounds Trumpeter - Fixed that counters added to permanents entering the battlefield were not taken into account. 2017-01-20 19:01:11 +01:00
LevelX2
509139bb4a * Steel Golem - Fixed not correct working "dont cast" effect. 2017-01-20 15:46:17 +01:00
Quercitron
292c9f6eba * Hope of Ghirapur - Fix that ability could be activated if Hope of Ghirapur was removed from the battlefield and returned back (fixes #2808). 2017-01-20 04:20:43 +03:00
LevelX2
6625bf86be Xmage 1.4.21V0 2017-01-15 17:44:02 +01:00
LevelX2
75cbfdf3b9 * Some changes to EnterTheBattlefield events, some other fixes (fixes #2765). 2017-01-15 15:22:33 +01:00
LevelX2
78cff4d24f * Fixed Flailing Drake and test. 2017-01-14 15:47:33 +01:00
LevelX2
1c1e4daaf3 * Vorinclex, Voice of Hunger - FIxed a bug that id did not work correctly with some conditional land mana sources (e.g. Gemstone Caverns). 2017-01-14 12:26:22 +01:00
Alexsandro
1d91e04ac1 Add Hivestone tests 2017-01-11 14:08:34 -02:00
igoudt
ac8962cb29 replaced enum comparison from equals to == 2017-01-11 09:53:16 +01:00
LevelX2
1c4bf298eb Merge pull request #2762 from sotovdev/bigRefactoring
Big refactoring
2017-01-11 07:42:52 +01:00
LevelX2
d55dd515f3 Some minor fixes and some tests. 2017-01-10 23:52:38 +01:00
Alexsandro
4bf2137e9d Add hivestone test structure 2017-01-10 12:56:39 -02:00
Alexsandro
92cfe2403e Create cipher test for Muraganda Petroglyphs 2017-01-10 11:40:04 -02:00
vraskulin
076840df53 Big refactoring
I used Intellij IDEA to automatically refactor code to achive 3 goals.
1) get rid of anonymouse classes, and replace the with lamba to get more readeable and clean code (like in TableWaitingDialog).
2) make effectively final  variables actually final to avoid inadvertent changes on it in further releases and keep objects as immutable, as possible.
3)  Get rid of unused imports (most of the changes) in whole project classes.
2017-01-09 19:16:53 +03:00
LevelX2
20c2f3dde8 * Hanweir Militia Captain - Fixed that the P/T setting ability of Westvale Cult Leader was applied to recast Hanweir Militia Captain. 2017-01-08 18:36:32 +01:00
Alexsandro
3033dfecc4 Add tests based on gatherer 2017-01-08 15:18:02 -02:00
LevelX2
ee203cf981 Xmage Release 1.4.20V0 2017-01-08 01:36:05 +01:00
LevelX2
7ec9394a83 Merge origin/master
Conflicts:
	Mage.Sets/src/mage/sets/AetherRevolt.java
2017-01-06 21:57:18 +01:00
ludwig.hirth
aa375c687c * Uba Mask - Fixed some problems. 2017-01-03 17:18:34 +01:00
emerald000
60bad2407b Fighting Git, part 2. 2017-01-03 01:23:56 -05:00
ludwig.hirth
6c72794859 * Added test. 2016-12-29 17:05:32 +01:00
LevelX2
3a33fa4748 * Added Test for #2721. 2016-12-28 12:01:03 +01:00
LevelX2
ecc18072cf Cyclopean Tomb - Update. 2016-12-28 02:02:57 +01:00
LevelX2
f56c64af2d * Fixed a problem that Emblems created by permanents where its owner left the game caused errors in clients. Some handling cganges of emblems. 2016-12-27 16:01:09 +01:00
LevelX2
c05941cf0d * Added cascade test. 2016-12-24 10:16:03 +01:00
ludwig.hirth
ec4e50ece4 Added test. 2016-12-23 15:04:09 +01:00
ludwig.hirth
e5a5911c6e * Sacred Ground - Fixed that the Sacred Ground effect did also move the land if it was removed from graveyard since the ability triggered. 2016-12-23 12:29:33 +01:00
LevelX2
1de210ab74 * Fixed a bug of DealsDamageToOneOrMoreCreaturesTriggeredAbility, added some tests. 2016-12-18 17:50:33 +01:00
LevelX2
d85b9943f1 * Added logic to remove control effects that refer to permanents of a player that leaves the game. 2016-12-18 16:57:34 +01:00
LevelX2
da9e9a1180 * Fixed some possible null pointer exceptions and some minor editing. 2016-12-18 15:02:19 +01:00
LevelX2
61dd62b148 * Undiscovered Paradise - Fixed that it was not returned to hand on untap step (fixes #2693). 2016-12-17 09:27:24 +01:00
LevelX2
8d6d8d25e5 * Reflecting Pool - Fixed that mana from dynamic mana abilities were not taken into account (e.g. Gaea's Cradle or Serra's Sanctum). 2016-12-16 18:38:40 +01:00
LevelX2
79c80fe24b Added a test and some minor changes. 2016-12-11 23:10:20 +01:00
LevelX2
4b4aef8ed5 * Orzhov Advokist - Fixed that the attack preventing effect did not work correctly. 2016-12-11 16:25:08 +01:00
LevelX2
3d9b51bec3 * Animate Artifact - Fixed some problems. 2016-12-11 15:58:57 +01:00
LevelX2
fb2d3f911e * Power Surge - Fixed some problems. 2016-12-11 15:14:09 +01:00
LevelX2
561f120ce0 * Consecrete Land - Some changes. 2016-12-11 12:38:25 +01:00
LevelX2
b62ca1ed1f Xmage 1.4.19 2016-11-27 19:59:42 +01:00
LevelX2
8bf299e342 * Fixed and extended extra turn test. 2016-11-26 13:46:10 +01:00
Ryan Skeldon
949eb1acb0 Implemented Cairn Wanderer 2016-11-26 02:00:30 -05:00
Dilnu
3198558dd6 Fix March of the Machines
Add a DependencyType for ArtifactAddingRemoving and use it to make March of the Machines come after artifact type adding effects.
2016-11-22 08:40:54 -05:00
LevelX2
7daa476542 * Fixed that the color of cards cast face dwon and later turned face up was not set. 2016-11-20 22:34:12 +01:00
LevelX2
e6afdf0874 * Obscuring Aether - Fixed a problem that face down creatures had P/T = 0/0. 2016-11-20 10:15:11 +01:00
LevelX2
d3e6ae6bcd * Fixed test. 2016-11-20 10:12:21 +01:00
LevelX2
7d60d884c3 * Refelecting Pool - Fixed that mana that Exotic Orchard could produce was not taken into account. 2016-11-20 01:15:45 +01:00
LevelX2
4018d39dab Added test. 2016-11-20 00:45:18 +01:00
LevelX2
b7b7a97945 * Fixed that died creature were wrongly returned to battlefield also if it was moved to exile by replacement effect before. 2016-11-19 18:44:11 +01:00
LevelX2
bc61f66af1 * Merieke Ri Berit - Fixed a bug that controlled creatures after lost of control of Merieke were not destroyed. 2016-11-19 13:33:49 +01:00
LevelX2
0ccaca4a3b Fixed a problem that tokens that came into play with modified attributes (P/T e.g. from Master of Etherium) were seen for triggered abilities (e.g. Sword of the Meek ) with unmodified attributes. 2016-11-19 12:08:38 +01:00
LevelX2
cd61bf48d1 Added a test. 2016-11-13 22:29:26 +01:00
LevelX2
92a04be280 * Warp World - Fixed a bug caused by removing cards from library. 2016-11-12 17:32:57 +01:00
LevelX2
44f7b1b13c * Selvala, Explorer Returned - Fixed that the life gaining effect did not work. 2016-11-12 09:37:41 +01:00
LevelX2
c84d7ef49b Rite of the Raging Storm - Fixed bug that tokens were not doubled if the token was created by an effect controlled from other players (fixes #2584). 2016-11-12 09:00:09 +01:00
LevelX2
7cd105b951 Rite of the Raging Storm - Fixed some minor bugs (fixes #2584). 2016-11-12 08:45:43 +01:00
LevelX2
0db7a0427d * Bloodchief Ascension - Added test for triggered ability. All works as expected. (closes #2566). 2016-11-06 22:36:37 +01:00
LevelX2
c9e1b415e2 Xmage 1.4.18V0 2016-11-06 18:11:19 +01:00
Neil Gentleman
813c8cdd8a CreateTokenEffect already adds the article
don't want to end up with "a a 3/3 colorless Golem"

and also fixed fix tapped token rules text, which has changed
2016-11-05 11:27:36 -07:00
LevelX2
a4e1c7aefd Merge origin/master 2016-11-03 22:38:14 +01:00
LevelX2
d2561c1752 * Fixed a problem with triggered mana abilities. Fixed a problem that AI did not always select the needed mana color. Fixed a problem with Reflecting Pool not taking triggered mana abilities into account. 2016-11-03 22:37:54 +01:00
Neil Gentleman
ffa94811f6 fix compilation
broken in c38f96ae55
2016-11-01 21:28:42 -07:00
LevelX2
de28ea797e Merge pull request #2533 from magefree/issue-2492-emrakul-extra-turn
* Emrakul, the Promised End - Fix that extra turn is not giving when …
2016-10-31 07:36:11 +01:00
Quercitron
0dcc2a85b8 * Emrakul, the Promised End - Fix that extra turn is not giving when Emrakul is cast during an opponent's turn (fixes #2492). 2016-10-31 03:01:02 +03:00
Quercitron
75432f5b61 Revert rollback changes, fix rollback when extra turn was taken during an opponent's turn. 2016-10-31 02:51:40 +03:00
Quercitron
43581cafa3 Add assertActivePlayer test method. 2016-10-31 02:17:24 +03:00
LevelX2
1e07e52774 * Jace's Mindseeker - Fixed that no instant or sorcery could be cast from graveyard. 2016-10-30 00:27:52 +02:00
LevelX2
70126988c5 Changed rule text from "put token onto the battlefield" to "create token". 2016-10-29 23:42:19 +02:00
LevelX2
8b62eece68 XMage 1.4.17V0 2016-10-23 10:03:01 +02:00
LevelX2
c7744d8631 * Fixed a bug with tokens using the optional EntersBattlefieldEffect (e.g. Clone with Mimic Vat). 2016-10-23 00:36:36 +02:00
LevelX2
bf43ea9936 Added test and fixed some possible null pointer exception. 2016-10-22 12:45:50 +02:00
LevelX2
97b872d926 * Fixed that a spell that becomes a permanent didn't had the colors of the spell (e.g. ERsatz Gnomes). 2016-10-22 10:38:10 +02:00
LevelX2
ee96531de5 * Fixed that a spell that becomes a permanent didn't had the colors of the spell (e.g. ERsatz Gnomes). 2016-10-21 00:15:41 +02:00
fireshoes
89dd981075 Merge 2016-10-17 23:45:47 -05:00
LevelX2
157827addc XMage 1.4.16v0 2016-10-08 11:14:13 +02:00
LevelX2
984d94e64d Added test. 2016-10-07 14:49:27 +02:00
JOAC69
e8230946af Remove use of card classes for duplicate cards. Remove set related information from being tied to card classes. 2016-10-04 19:58:48 -05:00
LevelX2
1a8f38759b Fixed a problem with filetring of CantBeTargetedAllEffect. 2016-10-03 19:43:26 +02:00
LevelX2
24fc597fe5 Fixed mode handling for modes that can be selected multiple times. 2016-10-03 19:41:46 +02:00
LevelX2
5469facdd6 Added a test. 2016-10-02 16:15:04 +02:00
LevelX2
3516dc75e4 Updated POM to use Java 8. Updated some tool versions in the POMs. 2016-09-29 16:21:32 +02:00
LevelX2
1066472491 * Fixed a bug that modal spells did not work correctly (fixes #2397). 2016-09-28 23:31:52 +02:00